Provide simple BrowserKit integration #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #67. |
pamil
force-pushed
the
master-browserkit-integration
branch
from
9d5b241 to
b518f80
Compare
lchrusciel
approved these changes
May 20, 2019
pamil
force-pushed
the
master-browserkit-integration
branch
from
b518f80 to
ab61dba
Compare
lchrusciel
approved these changes
Aug 26, 2019
Zales0123
approved these changes
Aug 27, 2019
lchrusciel
approved these changes
Sep 9, 2019
| use Behat\Behat\Context\Context; | ||
| use FriendsOfBehat\SymfonyExtension\Mink\MinkParameters; | ||
| use Psr\Container\ContainerInterface; | ||
| use Symfony\Component\BrowserKit\Client; |
There was a problem hiding this comment.
For Symfony 5.0 we should add support for KernelBrowser as well
|
Thank you, Kamil! 🎉 |
|
I had an issue with it during PHPers workshop. Not it would work like charm 🎉 |
|
Related commit: 0f906e1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's already a service for BrowserKit's client, this PR adds acceptance scenarios and autowires it. The architecture might need some rework after introducing Panther support.