Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(talker_dio_logger): add enable option to control log output #276

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

weitsai
Copy link
Contributor

@weitsai weitsai commented Nov 10, 2024

Description

  • Added an enable option to talker_dio_logger to control whether to output logs.
  • This functionality mirrors the usage in talker_riverpod_logger, allowing selective logging for Dio requests.

Changes

  • Added enable flag in talker_dio_logger

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (eee26ea) to head (efce17e).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #276      +/-   ##
===========================================
+ Coverage   98.73%   100.00%   +1.26%     
===========================================
  Files          28         3      -25     
  Lines         555       102     -453     
===========================================
- Hits          548       102     -446     
+ Misses          7         0       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Frezyx
Copy link
Owner

Frezyx commented Nov 12, 2024

Hello @weitsai !
Thanks a lot for this contribution ❤️

Can you separate this pull-request for two parts?
Adding enabled field for TalkerLoggerSettings in talker_logger is different functionality and must be merged in newx package version

@Frezyx Frezyx added enhancement New feature or request addons Related to addons/bridge packages like dio_logger and bloc_logger labels Nov 12, 2024
@Frezyx Frezyx merged commit ed13088 into Frezyx:master Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Related to addons/bridge packages like dio_logger and bloc_logger enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants