Changed the code for more flexible interaction with custom logs. #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
==========================================
- Coverage 98.73% 97.81% -0.93%
==========================================
Files 28 14 -14
Lines 555 320 -235
==========================================
- Hits 548 313 -235
Misses 7 7 ☔ View full report in Codecov by Sentry. |
Frezyx
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is just for consideration, the idea is to make interaction with custom logs more flexible.
That is, the ability to define a key when creating a custom log and in the theme and settings parameters to accept a map not with an enam, but with a key that will match the color.
This would be especially convenient if there are users who use the talker and talker_flutter libraries, but make their own implementation of Talker Screen. Now the key is passed as null for custom logs.
Good log added only for example.