Add Custom Settings Bottom Sheet without needing existing code changes #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed filenames: base_card.dart -> talker_base_card.dart data_card.dart -> talker_data_card.dart snackbar.dart -> talker_snackbar_content.dart Moved talker_flutter/lib/src/ui/talker_settings/widgets/talker_setting_card.dart to talker_flutter/lib/src/ui/talker_settings Renamed class: BaseBottomSheet -> TalkerBaseBottomSheet New Exports: talker_settings.dart talker_base_card.dart talker_base_bottom_sheet.dart talker_data_card.dart talker_snackbar_content.dart
… creation If no creator passed into TalkerView - standard settings bottom sheet will be used Need to pass the settings bottom sheet creator in through TalkerScreen class
This allows easy access to HTTP result’s status codes when logs are collapsed
Example of adding a Custom Settings Bottom Sheet, with custom booleans
Frezyx
added
enhancement
|
Hello @wolfe719 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method for interested individuals to create custom settings bottom sheets.
This method does not require any code changes to existing projects.
An optional argument is added to the TalkerScreen() function, a settingsBottomSheetCreator function.
If set, the settingsBottomSheetCreator function is called to create a custom Bottom Sheet for settings.
An example project using this method is created - the sample custom settings BottomSheet creator has the three existing basic settings (Enabled, Use console logs, Use history), and adds two more: