-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve #3
Open
math-GH
wants to merge
7
commits into
FreshRSS:master
Choose a base branch
from
math-GH:improve
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve #3
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
76e9529
improve readme.md
math-GH a66bde1
about page
math-GH 7c3948c
fix title of about page
math-GH 311ca61
i18n en
math-GH e3a23bf
i18n fr
math-GH 106bfe3
added: i18n de
math-GH 3748437
readme: CSS+JS
math-GH File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,22 @@ | ||
Extension-HelloWorld | ||
==================== | ||
# Extension-HelloWorld | ||
|
||
An HelloWorld extension | ||
An HelloWorld extension for [FreshRSS](https://github.com/FreshRSS/FreshRSS). | ||
|
||
It is a bit described in the documentation: https://freshrss.github.io/FreshRSS/en/developers/03_Backend/05_Extensions.html#write-an-extension-for-freshrss | ||
|
||
## Warning | ||
|
||
It is not recommended to install this extension on your production server. This extension manipulates the important “About” page. | ||
|
||
## How to install | ||
|
||
To install this extension, download the extension archive first and extract it on your PC. Then, upload this on your server. Extensions must be in the `./extensions` directory of your FreshRSS installation. | ||
|
||
## What it does | ||
|
||
This extension is a little showcase and boilerplate for a FreshRSS extension. | ||
|
||
As showcase it will manipulate some little things: | ||
- the “About” page content will be overwritten | ||
- the “Save” button titles will be changed | ||
- the normal view article list will be changed |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
<?php | ||
|
||
/******************************************************************************/ | ||
/* Each entry of that file can be associated with a comment to indicate its */ | ||
/* state. When there is no comment, it means the entry is fully translated. */ | ||
/* The recognized comments are (comment matching is case-insensitive): */ | ||
/* + TODO: the entry has never been translated. */ | ||
/* + DIRTY: the entry has been translated but needs to be updated. */ | ||
/* + IGNORE: the entry does not need to be translated. */ | ||
/* When a comment is not recognized, it is discarded. */ | ||
/******************************************************************************/ | ||
|
||
return array( | ||
'hello_world' => array( | ||
'no_configuration' => 'Hier kann leider nichts konfiguriert werden!', | ||
'about' => array ( | ||
'title' => 'Über: Hello World FreshRSS', | ||
'content' => 'Eine neue „Über“ Seite, die von der Erweiterung „xExtension-HelloWorld“ überschrieben wurde' | ||
), | ||
), | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
<?php | ||
|
||
/******************************************************************************/ | ||
/* Each entry of that file can be associated with a comment to indicate its */ | ||
/* state. When there is no comment, it means the entry is fully translated. */ | ||
/* The recognized comments are (comment matching is case-insensitive): */ | ||
/* + TODO: the entry has never been translated. */ | ||
/* + DIRTY: the entry has been translated but needs to be updated. */ | ||
/* + IGNORE: the entry does not need to be translated. */ | ||
/* When a comment is not recognized, it is discarded. */ | ||
/******************************************************************************/ | ||
|
||
return array( | ||
'action' => array( | ||
'submit' => 'OK Hello World!', // IGNORE | ||
), | ||
'menu' => array( | ||
'about' => 'Über FreshRSS und Hello World', | ||
), | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,21 @@ | ||
<?php | ||
|
||
/******************************************************************************/ | ||
/* Each entry of that file can be associated with a comment to indicate its */ | ||
/* state. When there is no comment, it means the entry is fully translated. */ | ||
/* The recognized comments are (comment matching is case-insensitive): */ | ||
/* + TODO: the entry has never been translated. */ | ||
/* + DIRTY: the entry has been translated but needs to be updated. */ | ||
/* + IGNORE: the entry does not need to be translated. */ | ||
/* When a comment is not recognized, it is discarded. */ | ||
/******************************************************************************/ | ||
|
||
return array( | ||
'hello_world' => array( | ||
'no_configuration' => 'There is nothing to configure in this extension, sorry!', | ||
'about' => array ( | ||
'title' => 'About: Hello World FreshRSS', | ||
'content' => 'A new about page that was overwritten by the extension “xExtension-HelloWorld”' | ||
), | ||
), | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,20 @@ | ||
<?php | ||
|
||
/******************************************************************************/ | ||
/* Each entry of that file can be associated with a comment to indicate its */ | ||
/* state. When there is no comment, it means the entry is fully translated. */ | ||
/* The recognized comments are (comment matching is case-insensitive): */ | ||
/* + TODO: the entry has never been translated. */ | ||
/* + DIRTY: the entry has been translated but needs to be updated. */ | ||
/* + IGNORE: the entry does not need to be translated. */ | ||
/* When a comment is not recognized, it is discarded. */ | ||
/******************************************************************************/ | ||
|
||
return array( | ||
'action' => array( | ||
'submit' => 'Save', | ||
'submit' => 'OK Hello World!', | ||
), | ||
'menu' => array( | ||
'about' => 'About FreshRSS and Hello World', | ||
), | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,21 @@ | ||
<?php | ||
|
||
/******************************************************************************/ | ||
/* Each entry of that file can be associated with a comment to indicate its */ | ||
/* state. When there is no comment, it means the entry is fully translated. */ | ||
/* The recognized comments are (comment matching is case-insensitive): */ | ||
/* + TODO: the entry has never been translated. */ | ||
/* + DIRTY: the entry has been translated but needs to be updated. */ | ||
/* + IGNORE: the entry does not need to be translated. */ | ||
/* When a comment is not recognized, it is discarded. */ | ||
/******************************************************************************/ | ||
|
||
return array( | ||
'hello_world' => array( | ||
'no_configuration' => 'Il n’y a rien à configurer dans cette extension, désolé !', | ||
), | ||
'about' => array ( | ||
'title' => 'About: Hello World FreshRSS', // TODO | ||
'content' => 'A new about page that was overwritten by the extension “xExtension-HelloWorld”' // TODO | ||
), | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,20 @@ | ||
<?php | ||
|
||
/******************************************************************************/ | ||
/* Each entry of that file can be associated with a comment to indicate its */ | ||
/* state. When there is no comment, it means the entry is fully translated. */ | ||
/* The recognized comments are (comment matching is case-insensitive): */ | ||
/* + TODO: the entry has never been translated. */ | ||
/* + DIRTY: the entry has been translated but needs to be updated. */ | ||
/* + IGNORE: the entry does not need to be translated. */ | ||
/* When a comment is not recognized, it is discarded. */ | ||
/******************************************************************************/ | ||
|
||
return array( | ||
'action' => array( | ||
'submit' => 'Sauvegarder', | ||
'submit' => 'OK Hello World!', // TODO | ||
), | ||
'menu' => array( | ||
'about' => 'About FreshRSS and Hello World', // TODO | ||
Comment on lines
-5
to
+18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TODO left: please support here with the French translation |
||
), | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,19 @@ | ||
<div class="post content"> | ||
<h1>About</h1> | ||
<p>A new about page!</p> | ||
</div> | ||
<?php | ||
/** @var FreshRSS_View $this */ | ||
if (FreshRSS_Auth::hasAccess()) { | ||
$this->partial('aside_configure'); | ||
} | ||
?> | ||
|
||
<main class="post content<?= !FreshRSS_Auth::hasAccess() ? ' centered' : ''?>"> | ||
<h1><?= _t('ext.hello_world.about.title')?></h1> | ||
<p><?= _t('ext.hello_world.about.content')?></p> | ||
</main> | ||
|
||
<?php if (!FreshRSS_Auth::hasAccess()) { ?> | ||
<footer class="main-footer"> | ||
<?php if (file_exists(TOS_FILENAME)) { ?> | ||
<a href="<?= _url('index', 'tos') ?>"><?= _t('index.tos.title')?></a> | ||
<?php } ?> | ||
</footer> | ||
<?php } ?> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO left: please support here with the French translation