[payments] Add VAT to the gross amount for matching values in the accounts page in SDK #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bahiirwa
commented
Oct 16, 2025
bahiirwa
commented
- Add VAT to the gross amount to ensure the accounts page in SDK has matching values to the customer portal and invoice.
bahiirwa
changed the title
fajardoleo
reviewed
Oct 28, 2025
| */ | ||
| function formatted_gross() | ||
| { | ||
| $price = round($this->gross + $this->vat, 2); |
There was a problem hiding this comment.
@bahiirwa Missing spaces, but do we still need round() here? (We're already rounding the value when calling number_format().)
There was a problem hiding this comment.
Considering we do not have a great need for precision like a DB save and only one comparison operation, we can get rid of round().
… has matching values to the customer portal and invoice.
bahiirwa
force-pushed
the
feature/laurence/update-gross-amount-with-vat
branch
from
551fe04 to
51f54c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.