Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always hook the data sync cron event callback #791

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnbillion
Copy link

Currently the cron event callback to sync data is only hooked when the cron runner is actually running. This causes a few problems:

  • A cron management plugin such as WP Crontrol will flag the event as having no action.
  • Using an alternative cron runner such as Cavalcade will result in the action firing but the callback not being hooked. The callback will never get called.

There is no need to conditionally hook the cron event callback only when cron is running. This fixes that.

Before

2025-03-06-13 35 49

After

2025-03-06-13 35 30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant