Fix cross channel videos link sometimes broken #8276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
force-pushed
the
fix/local-cross-channel-author-link
branch
from
b2b1788 to
9af908f
Compare
Member
|
Im a bit confused about this PR. What does it solve? Maybe add before and after screenshots so my Magikarp brain understands |
Collaborator
Author
|
Oh before fix you see links with channel ID like |
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
* development: (22 commits) Workaround ready-to-show not firing consistently on wayland (FreeTubeApp#8294) Bump electron from 38.4.0 to 39.2.1 (FreeTubeApp#8303) Migrate the WatchVideoInfo component to the composition API (FreeTubeApp#8295) Translated using Weblate (Hungarian) Translated using Weblate (Norwegian Bokmål) Translated using Weblate (French) Bump eslint-plugin-jsdoc from 61.1.12 to 61.2.1 in the eslint group (FreeTubeApp#8298) Replace broken trending with a local API only equivalent (FreeTubeApp#8289) Fix settings layout issues after the Vue 3 migration (FreeTubeApp#8292) Bump lefthook from 2.0.3 to 2.0.4 (FreeTubeApp#8299) Bump shaka-player from 4.16.8 to 4.16.9 (FreeTubeApp#8301) Bump electron-builder from 26.1.0 to 26.2.0 (FreeTubeApp#8302) Fix playlist video view counts on the local API (FreeTubeApp#8290) change hardcoded color app text logoColor (FreeTubeApp#8288) Translated using Weblate (Russian) Translated using Weblate (German) wrap long playlist strings (FreeTubeApp#8275) Translated using Weblate (Bulgarian) Bump js-yaml from 4.1.0 to 4.1.1 (FreeTubeApp#8284) bump workflows node-version to 24 (FreeTubeApp#8279) ... # Conflicts: # src/renderer/helpers/api/invidious.js
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
PikachuEXE
requested review from
ChunkyProgrammer,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
Contributor
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
* development: (123 commits) Translated using Weblate (Slovak) Translated using Weblate (Slovak) Translated using Weblate (Slovak) add skip to previous/next video buttons in media player (FreeTubeApp#8285) Translated using Weblate (Slovak) Translated using Weblate (Slovak) Translated using Weblate (German) Bump express from 4.21.2 to 4.22.0 (FreeTubeApp#8374) Bump electron-builder from 26.3.0 to 26.3.2 (FreeTubeApp#8370) Translated using Weblate (Hebrew) Bump the eslint group with 2 updates (FreeTubeApp#8367) Translated using Weblate (Portuguese) Bump stylelint from 16.26.0 to 16.26.1 in the stylelint group (FreeTubeApp#8368) Bump vue-i18n from 11.1.12 to 11.2.2 (FreeTubeApp#8369) Bump electron from 39.2.3 to 39.2.4 (FreeTubeApp#8371) Bump mikefarah/yq from 4.49.1 to 4.49.2 (FreeTubeApp#8372) Translated using Weblate (Slovak) Translated using Weblate (Slovak) Translated using Weblate (Slovak) Translated using Weblate (Slovak) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Description
There are some cross channel (cross 2 channels) videos and sometimes the handling is faulty (already handled sometimes)
Like having channel links with channel ID like
N/Aor empty string and if you click it you see no such channel messageThis PR fixes those missing places
Screenshots
Testing
Local API + IV API
Moore's Law Is Dead and Ancient Gameplays, Look forNvidia RTX 5080 SUPER Cancelled? AMD RX 9080 XT & RDNA 5 🧐 | Ancient Gameplays | Broken Silicon 335, ensure no channel link (no way to infer)Desktop
Additional context
IV got no channel link for those videos which might or might not be improved in this PR (not a.t.m. of writing)
Update 1: Fixed IV API to be the same as local API