Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly Show View Count for Video when there is Zero Views #6596

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Correctly Show View Count for Video when there is Zero Views #6596

wants to merge 1 commit into from

Conversation

SudharakaP
Copy link
Contributor

@SudharakaP SudharakaP commented Jan 16, 2025 •
edited
Loading

Title

Correctly Show View Count for Video when there is Zero Views

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Resolve #6568

Description

This PR solve the issue of showing NaN Views when there's zero view count for a video

Screenshots

image

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 16, 2025 20:40
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 16, 2025
@SudharakaP SudharakaP mentioned this pull request Jan 16, 2025
Open
6 tasks
@absidue
Copy link
Member

absidue commented Jan 16, 2025

Please change it in the local API parsing not in the display code. If we know that there are zero views we should show 0 views, we only hide stuff when the information is not available (e.g. published dates on the channel shorts tab).

@absidue absidue added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jan 16, 2025
@SudharakaP SudharakaP changed the title Do Not Views for Video when there is Zero Views Correctly Show View Count for Video when there is Zero Views Jan 16, 2025
auto-merge was automatically disabled January 16, 2025 20:55

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 16, 2025 20:56
auto-merge was automatically disabled January 16, 2025 20:59

Head branch was pushed to by a user without write access

@SudharakaP SudharakaP force-pushed the fix/do-not-show-view-count-when-zero branch from a9d4063 to b57f44c Compare January 16, 2025 20:59
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 16, 2025 20:59
@SudharakaP
Copy link
Contributor Author

SudharakaP commented Jan 16, 2025 •
edited
Loading

Please change it in the local API parsing not in the display code. If we know that there are zero views we should show 0 views, we only hide stuff when the information is not available (e.g. published dates on the channel shorts tab).

@absidue : Done, let me know if you see any issues

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@dinglerod
Copy link

That is a display issue, isn't it? Should the function extractNumberFromString(str) really return zero if there's no number in the string? NaN is clearly more appropriate.

Displaying a NaN view count as zero should be safe. Redefining NaN to be zero? Not so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absidue absidue Awaiting requested review from absidue

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
PR: changes requested PR: stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Videos with no views say "NaN views" instead of "0 views"
3 participants
@SudharakaP @absidue @dinglerod