Patch statemachine to work with example #1663
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oroulet
reviewed
Jun 20, 2024
my-changes.patch
Outdated
| @@ -0,0 +1,36 @@ | |||
| From 7a5311b4f1094dff434df43acc46ead4d1b2d7a0 Mon Sep 17 00:00:00 2001 | |||
|
That was added by mistake. I’ll remove it.
Dr. Terrence McGuckin
(they/them)
215 531 4703
Founder
Ephemeron Labs
3525 I street
Suite 07
Philadelphia, PA 19134
…On Thu, Jun 20, 2024 at 8:46 AM oroulet ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In my-changes.patch
<#1663 (comment)>
:
> @@ -0,0 +1,36 @@
+From 7a5311b Mon Sep 17 00:00:00 2001
what is that file?
—
Reply to this email directly, view it on GitHub
<#1663 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABO3DQCLDHNJ7GZ424IIPDZILFKHAVCNFSM6AAAAABJS2G62GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZQGMZDONZUGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
As sidenote: StateVariableType: https://reference.opcfoundation.org/Core/Part5/v104/docs/B.4.3 BaseDataType!!! so it can be any BaseDataType / Subtype of it e.g. NodeId Id is a name which uniquely identifies the current state within the StateMachineType. A subtype may restrict the DataType. I chose NodeId at that time because the State-ObjectType-Instance has a unique id (node-id) in the Addressspace! i am not sure if the change is valid!? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We modified the library so the state machine works with the example provided