Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI on python 3.12 #1528

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CI on python 3.12 #1528

wants to merge 2 commits into from

Conversation

oroulet
Copy link
Member

@oroulet oroulet commented Dec 16, 2023

unfortunately one test seems broken on python 3.12 and I have no ideas why....
Cannot reproduce if we run that test alone....

@oroulet oroulet self-assigned this Dec 16, 2023
@oroulet oroulet changed the title CI stuff CI on python 3.12 Dec 18, 2023
@AiyionPrime
Copy link
Contributor

AiyionPrime commented Feb 17, 2024

I reproduced the same behaviour locally on a python 3.12 without performance optimizations: Same issue.

I did a binary search on the tests and found (at least) two which are 'helping' the failing test not to run into a timeout.

I think its the subscription line in e.g. test_set_monitoring_mode:
await opc.opc.create_subscription(100, None)

Removing all other except the failing test and this reduced snippet:

@pytest.mark.parametrize("opc", ["client"], indirect=True)
async def test_set_monitoring_mode(opc):
    await opc.opc.create_subscription(100, None)

leads to your found tested issue.

I'm not sure yet, what change in python 3.12 introduced the problem, but I thought sharing this early might help others seeing the problem faster than me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants