Add a custom CORS proxy for our clients #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indeyets
requested changes
Jan 4, 2025
|
|
||
| ctx.status = response.status; | ||
|
|
||
| for (const header of headersToPass) { |
There was a problem hiding this comment.
It's the only place where headersToPass is used. Maybe it's better to inline it here? Will be more readable. [...].forEach((header) => {})
|
|
||
| if (typeof origin !== 'string') { | ||
| if (!allowedOrigins.includes('none')) { | ||
| throw new BadRequestException('Missing origin'); |
There was a problem hiding this comment.
Status 400 means that user has a chance to fix the situation. But it's not the case as origin is not manually chosen.
We need some other Status I believe
There was a problem hiding this comment.
I don't think that we have any better option. It is the client error (definitely not the server one), i.e. some of the 4xx codes. The 400 means 'some problem with the request that we can't specify more clearly by other 4xx codes'.
Of the other codes, only the 403 is more or less fits.
davidmz
force-pushed
the
cors-proxy
branch
2 times, most recently
from
28cf81d to
f540bfa
Compare
indeyets
previously approved these changes
Jan 4, 2025
indeyets
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
GET /v2/cors-proxy?url=.... This method acts as a simple proxy for web clients that need to make requests to other origins (specifically, to oEmbed endpoints of media providers). The proxy is deliberately limited: the valid request origins and URL prefixes are defined in the server config (see the corsProxy config entry).