-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PhotoSwipe to v5, rewrite lightbox logic #1662
Conversation
♻️ PR Preview 9b21e0f has been successfully destroyed since this PR has been closed. 🤖 By surge-preview |
It allow to see low-res placeholder while the hi-res image loading
if (mediaType === 'image') { | ||
return { | ||
// Convert dropbox page URL to image URL | ||
src: url.replace( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А это точно так работает? Вот прямая ссылка на картинку (через кнопку "скопировать ссылку в веб-интерфейсе") https://www.dropbox.com/scl/fi/7oubm0u9vsq1nbbe0lo6f/2023-01-01-11.16.44.jpg?rlkey=g0yffcfr4jnrd945tbwrvs70d&dl=0, а вот ссылка на сам файл: https://uc2812d73f847f48fc73fe3919c1.previews.dropboxusercontent.com/p/thumb/ACLK0x4L7PH7KIjpGHaiFyLy9SWjxuYXNbJQ0Q63koJy3yDUXLG0lXY7s1B3hjo3pPY_mILxZqaoB_aLGvi4Rk09p4dKJAOwJsFhPRlSPZ304DNiKBZufOoMRS2q3WgPlpo5JNuJSAHXRNy718pEXHgq18tdxSOzAOJmic_nSL99aiUM9c-nodQpfKeI7Ou_jqHL7tD7jiM2uqzpxd2KHb5f7LZEe-fepW21qjTFU3B9KTvXvscS19TE03Tw4tSsk_0ZK2NHXqmDsC0ADRsrmSb-seQvtYKjgww69Q31Hp2YR5IxbPwi_yfYlZmegbQQGhJ_wW6aFeYNRqNxsPsHSn70Ar_arVg2oY1suTHXMVJV0w-DMEAH2mAuyUn_F03ZbWI/p.jpeg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
И не стоит ли этот replace унести в getEmbeddableItem?
src/components/media-opener.jsx
Outdated
if (!iframe.contentDocument) { | ||
// Document is inaccessible (so it has another domain). We can try to | ||
// play. | ||
iframe.contentWindow.postMessage( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это автоплей получается?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Титаническая работа!
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
No description provided.