Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PhotoSwipe to v5, rewrite lightbox logic #1662

Merged
merged 19 commits into from
Jan 19, 2024
Merged

Update PhotoSwipe to v5, rewrite lightbox logic #1662

merged 19 commits into from
Jan 19, 2024

Conversation

davidmz
Copy link
Member

@davidmz davidmz commented Jan 9, 2024

No description provided.

Copy link

github-actions bot commented Jan 9, 2024

♻️ PR Preview 9b21e0f has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@davidmz davidmz requested review from indeyets and n1313 January 13, 2024 10:43
@davidmz davidmz marked this pull request as ready for review January 13, 2024 10:43
if (mediaType === 'image') {
return {
// Convert dropbox page URL to image URL
src: url.replace(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И не стоит ли этот replace унести в getEmbeddableItem?

if (!iframe.contentDocument) {
// Document is inaccessible (so it has another domain). We can try to
// play.
iframe.contentWindow.postMessage(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это автоплей получается?

n1313
n1313 previously approved these changes Jan 14, 2024
Copy link
Contributor

@n1313 n1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Титаническая работа!

@davidmz davidmz merged commit c173d96 into stable Jan 19, 2024
3 checks passed
@davidmz davidmz deleted the photoswipe branch January 19, 2024 14:51
Copy link

sentry-io bot commented Jan 20, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'src') openLightbox(src/services/lightbox) View Issue
  • ‼️ TypeError: Failed to fetch cachedFetch(src/components/link-preview/helpers... View Issue
  • ‼️ TypeError: Importing a module script failed. <anonymous>(src/services/lightbox) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants