Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to avoid tenacity retry wait times when we're using vcr cassettes #58

Closed
sckott opened this issue Jan 9, 2025 · 1 comment
Assignees
Labels
infrastructure Infrastructure fix to execute WDL GitHub Actions

Comments

@sckott
Copy link
Collaborator

sckott commented Jan 9, 2025

The problem is thus: A huge advantage of using vcr is that tests run quickly -> you can then iterate quickly b/c you don't have to lose train of thought while you make change, run tests, make change, repeat.

However, right now we use tenacity to do HTTP retries for some methods in the CromwellApi class when we do REAL HTTP requests because if we do a request too early we may get a 404, but if we do a back off and wait a bit and try again we may get a 200 response, great.

Options:

related #52

@tefirman tefirman added the infrastructure Infrastructure fix to execute WDL GitHub Actions label Jan 14, 2025
@sckott sckott self-assigned this Jan 24, 2025
@sckott
Copy link
Collaborator Author

sckott commented Feb 11, 2025

this is done, forgot to close this via other work - through adding the recording_mode fixture we can then basically set the sleep time to 0 when we're using cached vcr cassettes

@sckott sckott closed this as completed Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure fix to execute WDL GitHub Actions
Projects
None yet
Development

No branches or pull requests

2 participants