43 nested json handling #101
Conversation
|
@tefirman for this PR we are testing if the runtime variables that have been provided in a json format are being provided. Which is basically testing if runtime variables can be given to a WDL from a JSON. However if we want to test if Cromwell is actually getting the runtime variables I am asking for I think we will have to write a slightly different unit test. Both unit tests in my opinion are valid, independent and needed. |
@sitapriyamoorthi , I think you might be referring to #98 ? |
| } | ||
|
|
||
| runtime { | ||
| docker: "ubuntu:latest" |
There was a problem hiding this comment.
| docker: "ubuntu:latest" | |
| docker: "ubuntu:20.04" |
Probably want to stay away from latest tag.
| allSampleInfo="~{sample.sampleName} | ~{sample.aboutSample} | ~{sample.sampleDescription} | ~{sample.details.experimentType} | ~{sample.details.prepMethod} | ~{sample.details.tissueType}" | ||
|
|
||
| # Output the concatenated sample info to a file | ||
| echo ${allSampleInfo} > ~{base_file_name}.allSampleInfo.txt |
There was a problem hiding this comment.
| echo ${allSampleInfo} > ~{base_file_name}.allSampleInfo.txt | |
| echo "${allSampleInfo}" > ~{base_file_name}.allSampleInfo.txt |
Adding quotations to account for spaces.
unit test to test nested jsons.
Closes #43