Skip to content

Commit

Permalink
Allow using thirdparty VID for reboot interface
Browse files Browse the repository at this point in the history
Filtering by `--vid` and `--pid` is not enough currently.

I'm implementing the reboot interface for a custom device. But I'm not using the Raspberry PI vendor ID.
There's no way currently to allow those third party devices to reboot.

With this change I can reboot my device from application firmware into bootloader with:

```
picotool reboot --vid 0x32ac --pid 0x001f -f -u
```

Signed-off-by: Daniel Schaefer <[email protected]>
  • Loading branch information
JohnAZoidberg committed Nov 19, 2024
1 parent 78c9bd1 commit 5788b3b
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions picoboot_connection/picoboot_connection.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

#include "picoboot_connection.h"
#include "boot/bootrom_constants.h"
#include "pico/stdio_usb/reset_interface.h"

#if ENABLE_DEBUG_LOG
#include <stdio.h>
Expand Down Expand Up @@ -142,6 +143,17 @@ enum picoboot_device_result picoboot_open_device(libusb_device *device, libusb_d
}
}

// Runtime reset interface with thirdparty VID
if (!ret) {
for (int i = 0; i < config->bNumInterfaces; i++) {
if (config->interface[i].altsetting[0].bInterfaceClass == 0xff &&
config->interface[i].altsetting[0].bInterfaceSubClass == RESET_INTERFACE_SUBCLASS &&
config->interface[i].altsetting[0].bInterfaceProtocol == RESET_INTERFACE_PROTOCOL) {
return dr_vidpid_stdio_usb;
}
}
}

if (!ret) {
if (config->bNumInterfaces == 1) {
interface = 0;
Expand Down

0 comments on commit 5788b3b

Please sign in to comment.