chromium_ec: Add more command IDs

Signed-off-by: Daniel Schaefer <[email protected]>
FrameworkComputer · Oct 18, 2023 · a64ea36 · a64ea36
1 parent 4630bdf
commit a64ea36
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 12 deletions.
diff --git a/framework_lib/src/chromium_ec/command.rs b/framework_lib/src/chromium_ec/command.rs
@@ -32,12 +32,34 @@ pub enum EcCommands {
     ChassisOpenCheck = 0x3E0F,
     /// Get information about historical chassis open/close (intrusion) information
     ChassisIntrusion = 0x3E09,
+
+    /// Not used by this library
+    AcpiNotify = 0xE10,
+
     /// Get information about PD controller version
     ReadPdVersion = 0x3E11,
+
+    /// Not used by this library
+    StandaloneMode = 0x3E13,
     /// Get information about current state of privacy switches
     PriavcySwitchesCheckMode = 0x3E14,
+    /// Not used by this library
+    ChassisCounter = 0x3E15,
     /// On Framework 16, check the status of the input module deck
     CheckDeckState = 0x3E16,
+    /// Not used by this library
+    GetSimpleVersion = 0x3E17,
+    /// GetActiveChargePdChip
+    GetActiveChargePdChip = 0x3E18,
+
+    /// Set UEFI App mode
+    UefiAppMode = 0x3E19,
+    /// Get UEFI APP Button status
+    UefiAppBtnStatus = 0x3E1A,
+    /// Get expansion bay status
+    ExpansionBayStatus = 0x3E1B,
+    /// Get hardware diagnostics
+    GetHwDiag = 0x3E1C,
 }
 pub trait EcRequest<R> {
     fn command_id() -> EcCommands;

diff --git a/framework_lib/src/chromium_ec/commands.rs b/framework_lib/src/chromium_ec/commands.rs
@@ -212,9 +212,9 @@ pub struct EcRequestUefiAppMode {
     pub enable: u8,
 }
 
-impl EcRequestRaw<()> for EcRequestUefiAppMode {
-    fn command_id_u16() -> u16 {
-        0x3E19
+impl EcRequest<()> for EcRequestUefiAppMode {
+    fn command_id() -> EcCommands {
+        EcCommands::UefiAppMode
     }
 }
 
@@ -226,9 +226,9 @@ pub struct EcResponseUefiAppBtnStatus {
     pub status: u8,
 }
 
-impl EcRequestRaw<EcResponseUefiAppBtnStatus> for EcRequestUefiAppBtnStatus {
-    fn command_id_u16() -> u16 {
-        0x3E1A
+impl EcRequest<EcResponseUefiAppBtnStatus> for EcRequestUefiAppBtnStatus {
+    fn command_id() -> EcCommands {
+        EcCommands::UefiAppBtnStatus
     }
 }
 
@@ -294,9 +294,9 @@ impl EcResponseExpansionBayStatus {
     }
 }
 
-impl EcRequestRaw<EcResponseExpansionBayStatus> for EcRequestExpansionBayStatus {
-    fn command_id_u16() -> u16 {
-        0x3E1B
+impl EcRequest<EcResponseExpansionBayStatus> for EcRequestExpansionBayStatus {
+    fn command_id() -> EcCommands {
+        EcCommands::ExpansionBayStatus
     }
 }
 
@@ -354,8 +354,8 @@ impl EcResponseGetHwDiag {
     }
 }
 
-impl EcRequestRaw<EcResponseGetHwDiag> for EcRequestGetHwDiag {
-    fn command_id_u16() -> u16 {
-        0x3E1C
+impl EcRequest<EcResponseGetHwDiag> for EcRequestGetHwDiag {
+    fn command_id() -> EcCommands {
+        EcCommands::GetHwDiag
     }
 }