Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add particle advection example #65

Closed

Conversation

jbisits
Copy link
Collaborator

@jbisits jbisits commented Sep 5, 2022

This PR adds an example where we are advecting particles in a flow. I was thinking about #2 and thought that if we just set diffusivity to be zero we are solving the advection equation so could maybe use that in lieu (or until) of having some kind of module that advects parcels. It is a little rough and ready but interested to see if you think it worthwhile.

@jbisits jbisits requested a review from navidcy September 5, 2022 11:26
@jbisits jbisits added the docs label Sep 5, 2022
@navidcy navidcy changed the title Joey add particle advection example Add particle advection example Sep 5, 2022
@navidcy
Copy link
Member

navidcy commented Sep 5, 2022

When I run the example I get this...

particle-advection.mp4

It's probably tricky to work without diffusivity due to numerical instabilities?

@jbisits
Copy link
Collaborator Author

jbisits commented Sep 5, 2022

When I run the example I get this...

particle-advection.mp4
It's probably tricky to work without diffusivity due to numerical instabilities?

Yes I did not think the one I ran locally was quite that bad, but the lack of diffusivity does cause problems with numerical instabilities. More seeing if you thought worth pursuing but I think best if I remove this example altogether. If I just close this PR does it get archived but not merged?

@navidcy
Copy link
Member

navidcy commented Sep 5, 2022

Yeap, that's what will happen if you close.

@navidcy
Copy link
Member

navidcy commented Sep 5, 2022

It'll stay in your fork unless you delete that branch.

@jbisits
Copy link
Collaborator Author

jbisits commented Sep 5, 2022

Ok I think I might do that just in case some inspiration strikes.. Thanks for you help and sorry for the bother with this!

@jbisits jbisits closed this Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants