-
Notifications
You must be signed in to change notification settings - Fork 32
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixing sign error for mean meridional PV gradient
Qy
in `MultiLayer…
…QG` module (#329) * changed reduced gravity to have const. denominator * changed sign of Fp in multi layer Qy calc, line 367 * reverting to old definition of reduced grav to test bug fix with sign in Qy def * alternate (but still incorrect) definition of reduced gravity (shifted denominator by 1 index) to verify that you must have that denominator as constant for zero interior PV * changed sign error, but leaving reduced grav; just to create pull request from this fork to main repo * changing things so that I only have the sign error fixed, to create pull request to main GFjl repo * changing reduced grav definition to match current one in main repo * changing reduced gravity definition...hopefully last time * trying to fix reduced gravity merge conflict :') * remove backup files * adding examples for GFjl issue * fixed sign error in multilayerqg.jl ONLY * removed various multilayerqg files in src * Update Project.toml Updating version number for patch release * add nonlinear advection test for 3 layers * simplify tests --------- Co-authored-by: Matt Lobo <[email protected]> Co-authored-by: Navid C. Constantinou <[email protected]>
- Loading branch information
1 parent
d7e2526
commit 2620251
Showing
4 changed files
with
204 additions
and
49 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ name = "GeophysicalFlows" | |
uuid = "44ee3b1c-bc02-53fa-8355-8e347616e15e" | ||
license = "MIT" | ||
authors = ["Navid C. Constantinou <[email protected]>", "Gregory L. Wagner <[email protected]>", "and co-contributors"] | ||
version = "0.15.2" | ||
version = "0.15.3" | ||
|
||
[deps] | ||
CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters