Fix figures in Docs/Aliasing & Docs/Timestepping + add \citet ref style #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
one marker was hiding the other
navidcy
changed the title
navidcy
changed the title
jbisits
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs/Aliasing figure: one marker was hiding the other
Docs/Timestepping figure: legend was covering the plots
Also DocumenterCitations.jl changed the default style and we ended up with sentences like "[1] showed that this and that..."; enforced author-year style + citet
Also change the compat entry for CUDA 5 -> 5.4 since CUDA v5.4 renamed Mem.Device and Mem.DeviceBuffer to CUDA.DeviceMemory and this was making show tests fail on GPU. (This compat entry should have been changed in #369.)