removing code duplication.

[09harsh]

Description

This PR deal with the following:

1. Remove code duplication. We are running the same set of operation for different backup modes, I have extracted them into a single function.
2. Added a new test scenario that performs restore on an encrypted backup after running the describe command. The test is successful but we have a bug in json parsing and the field FileLevelEncryption is missing the describe command. For now I have put the test in Pending, I will remove that once we have a fix for the same.

Type of change

Please select one of the options below.

• Other

Discussion

Are there any design details that you would like to discuss further?
No

Testing

Performed manual testing,

Ran 6 of 11 Specs in 1429.983 seconds
SUCCESS! -- 6 Passed | 0 Failed | 4 Pending | 1 Skipped
PASS | FOCUSED

Documentation

Did you update relevant documentation within this repository?
N/A

If this change is adding new functionality, do we need to describe it in our user manual?
N/A

If this change is adding or removing subreconcilers, have we updated the core technical design doc to reflect that?
N/A

If this change is adding new safety checks or new potential failure modes, have we documented and how to debug potential issues?
N/A

Follow-up

Are there any follow-up issues that we should pursue in the future?
No

Does this introduce new defaults that we should re-evaluate in the future?
No

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

• Commit ID: a70476e
• Duration 1:51:30
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

• Commit ID: 54e6aa8
• Duration 1:59:05
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

• Commit ID: cbdea4b
• Duration 2:04:31
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

• Commit ID: cc6c1a5
• Duration 2:56:26
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

• Commit ID: 55f433a
• Duration 2:20:00
• Result: ❌ FAILED
• Error: Error while executing command: TEST_USERNAME=pr-${CODEBUILD_BUILD_NUMBER} make -kj -C e2e pr-tests. Reason: exit status 2
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

• Commit ID: 9182205
• Duration 1:53:57
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

• Commit ID: 1625968
• Duration 2:12:38
• Result: ❌ FAILED
• Error: Error while executing command: TEST_USERNAME=pr-${CODEBUILD_BUILD_NUMBER} make -kj -C e2e pr-tests. Reason: exit status 2
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[johscheuer]

This should be in another PR, we shouldn't mix a refactoring and adding new features if not strictly required for some reason.

[johscheuer]

I understand the idea, but I think we should keep them split since we are probably adding more tests in the future that are either specific for continuous backup or onetime backups, thought the latter is rather an exception.