Do not repeat @OptIn annotation for generated class #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
dewantawsif
force-pushed
the
fix/optin
branch
from
816b331 to
3cd31c1
Compare
|
Now that I think about it we should also dedupe the marker classes |
|
Thank you for the PR, it's working fine for me. If you want, please add the deduplication. Otherwise i will merge it like it is, in the next days |
|
I forgot to add this but there doesn't seem like a need to dedupe them explicitly. I've added a test case just in case. |
dewantawsif
force-pushed
the
fix/optin
branch
from
6d8e760 to
24730ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #767
🤔 DOD Checklist