fix(deps): clear high-severity npm audit advisories blocking every open PR - #1165
Merged
Merged
Conversation
…kfiles The `Audit: npm audit` gate (`npm audit --audit-level=high` over app/ui and app/api) went red on every open PR between 2026-09-02 and 2026-09-03. No PR changed anything — the advisory database did, and audit queries it live: - browserslist <=4.28.6 GHSA-c83g-rgw3-j3cx, GHSA-73wf-gq98-2v4g (UI) - fast-uri 3.0.0-3.1.5 GHSA-5jgf-p345-68v8, GHSA-f65p-4m7j-42xc, GHSA-fph4-wmhf-6fwf, GHSA-jqff-g426-hqxp (UI+API) Both are transitive. `npm audit fix --package-lock-only` resolves them without touching either package.json: UI browserslist 4.28.2->4.28.9, fast-uri 3.1.5->3.1.7, qs 6.15.1->6.16.0, @humanfs/node 0.16.7->0.16.8, plus caniuse-lite / electron-to-chromium / node-releases / baseline-browser-mapping / update-browserslist-db bumps API fast-uri 3.1.5->3.1.7, qs 6.15.2->6.16.0, side-channel 1.1.0->1.1.1 typed-rest-client moves 2.3.1 -> 2.3.0 in both. That is a deliberate downgrade, not a mistake: 2.3.1 pins `qs: "6.15.1"` exactly (the vulnerable build), while 2.3.0 declares `qs: "^6.14.1"` and floats up to the patched 6.16.0. Both satisfy the `~2.3.0` range its only consumer (@stryker-mutator/core, dev-only) asks for. Two moderate advisories remain by choice — uuid via exceljs, fixable only by `--force`, which downgrades exceljs to 3.4.0. They sit below the gate's high threshold. Verified locally: both audit gates pass; UI 157 files / 1283 tests and API 212 files / 2676 tests green with coverage thresholds met; the node-launcher UI build (the command CI runs) succeeds with all 7 crawler wizard plugins verified in the bundle. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011SDczMFDtCQDzTCkV4SpQr
WimvandenHeijkant
approved these changes
Sep 8, 2026
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshes the two
package-lock.jsonfiles to clear the high-severity advisories that turned theAudit: npm auditgate red on every open PR.What happened
.github/workflows/pr.ymlrunsnpm audit --audit-level=highoverapp/uiandapp/api. Between 2026-09-02 07:46Z (last passing audit run) and 2026-09-03 09:48Z (first failure), two new high-severity advisories landed against transitive dependencies already pinned inmain:browserslist≤4.28.6 (had 4.28.2)fast-uri3.0.0–3.1.5 (had 3.1.5)No PR changed anything —
npm auditqueries the advisory database live, so every PR with product changes flipped red simultaneously.Audit: npm auditfeedsCI Passed, the required check, so all of them are blocked.The change
npm audit fix --package-lock-onlyin both projects. Neitherpackage.jsonis touched — lockfile-only.UI (12 packages) —
browserslist4.28.2→4.28.9,fast-uri3.1.5→3.1.7,qs6.15.1→6.16.0,@humanfs/node0.16.7→0.16.8, pluscaniuse-lite,electron-to-chromium,node-releases,baseline-browser-mapping,update-browserslist-dbdata bumps.API (4 packages, 1 removed) —
fast-uri3.1.5→3.1.7,qs6.15.2→6.16.0,side-channel1.1.0→1.1.1, and the nestedtyped-rest-client/node_modules/qs@6.15.1drops out.Two things worth a second look
typed-rest-clientgoes 2.3.1 → 2.3.0 in both projects. That downgrade is deliberate, not a resolution accident: 2.3.1 pinsqs: "6.15.1"exactly — the vulnerable build — while 2.3.0 declaresqs: "^6.14.1"and floats up to the patched 6.16.0. Both satisfy the~2.3.0range its only consumer asks for, and that consumer is@stryker-mutator/core(dev-only, mutation testing).Two moderate advisories are left in place —
uuidviaexceljs, fixable only withnpm audit fix --force, which downgradesexceljsto 3.4.0 (a breaking change to Excel export). They are below the gate'shighthreshold, so this is a conscious deferral rather than an oversight.Verification
Run locally against a clean
npm cifrom the updated lockfiles:npm audit --audit-level=high— passes in bothapp/uiandapp/apinode app/desktop/scripts/build-node-launcher.mjs --ui-only(the exact command theBuild: Node-launcher UIjob runs) succeeds, with all 7 crawler wizard plugins verified in the bundleBlast radius
This unblocks the 10 open Dependabot PRs whose only failure is this gate (#1090–#1100). Three other PRs fail for their own unrelated reasons and still need work after this merges: #1146 (a broken docs cross-link caught by the docs-structure guard), #1089, and #1161.
🤖 Generated with Claude Code
https://claude.ai/code/session_011SDczMFDtCQDzTCkV4SpQr