Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update versions in github actions #359

Merged
merged 13 commits into from
Aug 12, 2024

Conversation

acharyakavita
Copy link
Contributor

@acharyakavita acharyakavita commented Aug 6, 2024

Description

As part of an internal Nearform Open Source audit, we're going through
and updating some GH actions to no longer use unsupported versions of
node.

Fixes # (issue)
Resolves github action warnings in CICD pipeline.

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@acharyakavita acharyakavita linked an issue Aug 6, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Aug 6, 2024

🦋 Changeset detected

Latest commit: 097540c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
webpack-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@acharyakavita acharyakavita self-assigned this Aug 6, 2024
Copy link
Member

@robwalkerco robwalkerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code coverage step passes, but the report upload fails.
Is that expected?

@robwalkerco
Copy link
Member

Is that expected?

We have agreed to ignore this code coverage upload for now

package.json Outdated Show resolved Hide resolved
@acharyakavita acharyakavita merged commit 9333a27 into master Aug 12, 2024
2 checks passed
@acharyakavita acharyakavita deleted the 358-webpack-dashboard-clear-pipeline-warnings branch August 12, 2024 16:18
@FormidableLabs FormidableLabs deleted a comment from Mati882023 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack-dashboard: clear pipeline warnings
3 participants