-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: resolve Y values being incorrectly transformed when xAxis LabelRotation Applied #504
base: main
Are you sure you want to change the base?
bugfix: resolve Y values being incorrectly transformed when xAxis LabelRotation Applied #504
Conversation
…ustments so Y values dont get reduced
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks @MisterMur! We'll take a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀
Description
Relates to Issue#501
resolves Y values being incorrectly transformed when xAxis LabelRotation Applied.
Before the Y scale was being reduced to adjust for rotated label dimensions. this fix adjusts the output window only so the yscale doesnt get altered even when apply label rotation
had to reorder label to be calculated at begining of function ahead of modifcation to the outputwindow
Error Befor Fix:

the Y - value at the 200 tick - displays ~245yvalue when a 45 degree label rotation applied
After fix:

Y value at 200 tick - displays expected ~200 YValue even with 45 degree label rotation applied
no change in depedencies
Fixes # (issue)
Type of Change
How Has This Been Tested?
This can be tested by adding
labelRotate: {number}
as property to the CartesianChart xAxis prop.ensure the y Values line up with expected values on ticks on chart even with label rotation applied.
Checklist: (Feel free to delete this section upon completion)
yarn run check:code
and all checks pass