Repository navigation
Version Packages - #1378
Merged
Merged
Version Packages#1378
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ryan-roemer
approved these changes
Oct 26, 2026
ryan-roemer
pushed a commit
that referenced
this pull request
Oct 27, 2026
## Problem The `changeset status` guard added in #1374 / #1377 does more than reject mixed changesets — `changeset status` also enforces changeset **presence**, failing when a package has changed with no covering changeset. That broke the automated **"Version Packages" PR** (#1378): its entire purpose is to *consume* the changesets and bump versions, so it always has changed packages and no changesets left behind, and the check fails it every time with: ``` error Some packages have been changed but no changesets were found. ``` Presence enforcement was never the intent of #1374 (which was about a *mixed* changeset silently freezing releases), and we don't want to require a changeset on every package-touching PR. ## Fix Run the validation only when a changeset file is actually present: ```yaml if [ -n "$(find .changeset -maxdepth 1 -name '*.md' ! -name 'README.md' -print -quit)" ]; then git show-ref --verify --quiet refs/heads/main || git branch main origin/main pnpm changeset status else echo "No changesets to validate." fi ``` - **Mixed/malformed changesets are still caught** — a bad changeset is a file, so the step runs and fails (verified locally). - **The "Version Packages" PR is skipped** — no changeset files present. - **No presence enforcement** — PRs without a changeset are no longer failed. ## Verification Locally, against the current `main`: - With the clean changeset present → step runs, `changeset status` passes (3 publishable packages). - With only `config.json` (+ `README.md`) present → step skips, as the Version Packages PR would. - With a planted mixed changeset → `changeset status` still errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
github-actions
Bot
force-pushed
the
changeset-release/main
branch
from
October 27, 2026 16:04
99f242c to
ce33e91
Compare
Member
|
Note -- I'm ignoring the create-spectacle failure as it's a version bump config thing that manifests pre-release and we're going to likely deprecate the package. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
create-spectacle@0.4.4
Patch Changes
spectacle@10.2.4
Patch Changes
spectacle-mdx-loader@0.1.3
Patch Changes