-
Notifications
You must be signed in to change notification settings - Fork 47
ci: add-snapshots-to-ci #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@@ -11,7 +11,7 @@ | |||
"clean": "shx rm -rf ./{coverage,dist,docs,node_modules,tmp}/ ./{packages,e2e}/*/{dist,node_modules}/ && git clean -fX -e \"!.env*,nx-cloud.env\"", | |||
"ci:release": "pnpm publish -r --no-git-checks && changeset tag", | |||
"ci:version": "changeset version && pnpm install --no-frozen-lockfile", | |||
"changeset": "pnpm changeset", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was causing recursion of the changeset command 🤦
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8edb3b1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
62db7fd
to
8edb3b1
Compare
|
||
- name: snapshot release | ||
if: ${{ steps.changesets.outputs.published == 'false' }} | ||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an output of the above changesets action.
So the thought process here is
-if we dont release, we can release a snapshot
-
so we checkout the
develop
branch (currently) -
then run
changeset version
passingsnapshot
we can name a snapshot by passing the name to it (in this case i called it snapshot). -
then call
pnpm publish -r ...
-r causes pnpm to create the topological graph of the packages so it should be in order -
tag is passed and called snapshot for sanity and so we arent overwriting latest in any registry
-
no-git-checks is a pnpm feature so that if we have git files uncommitted it will commit.
Questions I am unsure of with this flow:
If there is no changeset, i'd imagine it wouldn't publish. I say this because if i run the following locally i would get this
pnpm changeset version --snapshot snapshot ✔ 7749 16:31:50
> forgerock-javascript-sdk@ changeset /Users/ryan.basmajian/programming/forgerock-javascript-sdk
> changeset "version" "--snapshot" "snapshot"
🦋 warn No unreleased changesets found, exiting.
So it exits, but i'm not really sure about the next step. it feels like maybe we would want a more sophisticated script written in JS that says if we get a process exit here or if we get that text output, then we just exist the script.
Thoughts?
JIRA Ticket
Description
Just threw together something, unconfirmed if this works. I stole this from some other action workflows i found via github issues/questions.
Type of Change
Please Delete options that are not relevant
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Definition of Done
Check all that apply
Documentation