Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(association): return bad request when associated record is not destroy #688

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

nicolasalexandre9
Copy link
Member

… not destroy

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

Copy link

codeclimate bot commented Sep 12, 2024

Code Climate has analyzed commit a2bfb0c and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 0.0% (55% is the threshold).

This pull request will bring the total coverage in the repository to 50.5%.

View more on Code Climate.

@nicolasalexandre9 nicolasalexandre9 merged commit d293515 into main Sep 18, 2024
5 of 6 checks passed
@nicolasalexandre9 nicolasalexandre9 deleted the fix/delete-associated-records branch September 18, 2024 14:44
forest-bot added a commit that referenced this pull request Sep 18, 2024
## [9.3.16](v9.3.15...v9.3.16) (2024-09-18)

### Bug Fixes

* **association:** return bad request when associated record is not destroy ([#688](#688)) ([d293515](d293515))
@forest-bot
Copy link
Member

🎉 This PR is included in version 9.3.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants