fix(permission): forward action approval exception for return expected response #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 4e8db83 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 95.4% (55% is the threshold). This pull request will bring the total coverage in the repository to 50.5%. View more on Code Climate. |
matthv
approved these changes
Jul 18, 2024
| @@ -35,13 +37,16 @@ def is_smart_action_authorized?(user, collection, parameters, endpoint, http_met | |||
|
|
|||
| user_data = get_user_data(user['id']) | |||
| collections_data = get_collections_permissions_data | |||
| collection_name = ForestLiana.name_for(collection) | |||
| rescue | ||
| raise ForestLiana::Errors::ExpectedError.new(409, :conflict, "The collection #{collection} doesn't exist", 'collection not found') | ||
| raise ForestLiana::Ability::Exceptions::UnknownCollection.new(collection_name) |
| @@ -66,7 +71,7 @@ def is_chart_authorized?(user, parameters) | |||
|
|
|||
| private | |||
|
|
|||
| def get_user_data(user_id) | |||
| def get_user_data(user_id, force_fetch = true) | |||
forest-bot
added a commit
that referenced
this pull request
Jul 19, 2024
## [9.3.13](v9.3.12...v9.3.13) (2024-07-19) ### Bug Fixes * **permission:** forward action approval exception for return expected response ([#685](#685)) ([1e6333c](1e6333c))
|
🎉 This PR is included in version 9.3.13 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition of Done
General
Security