Fix lines deforming or disappearing when partially behind the camera #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceSentry
approved these changes
Jan 26, 2024
IceSentry
merged commit bcc2479
into
ForesightMiningSoftwareCorporation:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a line has one point behind the camera(near plane) then it would deform or, if the
depth_biassetting was set to a negative value, disappear.Solution
The issue is that performing a perspective divide does not work correctly for points behind the near plane and a perspective divide is used inside the shader to define the line width in screen space.
The solution is to perform near plane clipping manually inside the shader before the perspective divide is done.
I have not investigated the performance of this fix.
Related
Screenshots of this issue with Bevy's own lines: discord link
The identical PR to fix this same issue in Bevy: bevyengine/bevy#9470