Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 300 #307

Closed
wants to merge 4 commits into from
Closed

Issue 300 #307

wants to merge 4 commits into from

Conversation

kaiiam
Copy link
Collaborator

@kaiiam kaiiam commented May 13, 2024

Reusing issue 300 to add feature of enabling the use of animal_parent from the species_list file to replace 'animal' in both the parent class as well as the EQ axiom if it exists. Only applies to the rows with ID FOODON:00003004.

@kaiiam
Copy link
Collaborator Author

kaiiam commented May 13, 2024

I'm not sure why it also committed a change to animal_parts.tsv that wasn't intentional on my part, perhaps I didn't pull from upstream master correctly and had old changes? Or some other change like line endings made the tsv get written and re-written. The changes to organism_parts.py are what we wanted though. Let me know @ddooley if you want me to redo this in a new PR with only that file committed.

@kaiiam
Copy link
Collaborator Author

kaiiam commented May 13, 2024

Will redo this without the changes to animal_parts.tsv in another PR.

@kaiiam kaiiam marked this pull request as draft May 13, 2024 17:44
@kaiiam
Copy link
Collaborator Author

kaiiam commented Jun 10, 2024

Redone in #310. Also the changes with large diffs to introduced in the first two commits are already in the main version of animal_parts.tsv, so this can safely be ignored and deleted

@kaiiam kaiiam closed this Jun 10, 2024
@kaiiam kaiiam deleted the issue-300 branch June 10, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant