refactor: rewards #219
refactor: rewards #219
Conversation
Refactored rewards v1 and v2, then finalized gas estimation on rewards v2
|
commit: |
| const { hubAddress: rewardsV1Address } = hubChain.rewardsV1; | ||
| const rewardsV1Address = hubChain.rewards[REWARDS_TYPE.V1].hubAddress; |
There was a problem hiding this comment.
const rewardsV1Address = getHubRewardAddress(network, REWARDS_TYPE.V1);
There was a problem hiding this comment.
here we already have the hubChain, we should pass another param (network) just to be able to call that method
| const { hubAddress: rewardsV1Address } = hubChain.rewardsV1; | ||
| const rewardsV1Address = hubChain.rewards[REWARDS_TYPE.V1].hubAddress; |
There was a problem hiding this comment.
const rewardsV1Address = getHubRewardAddress(network, REWARDS_TYPE.V1);
| const { hubAddress: rewardsV2Address } = hubChain.rewardsV2; | ||
| const rewardsV2Address = hubChain.rewards[REWARDS_TYPE.V2].hubAddress; |
There was a problem hiding this comment.
const rewardsV2Address = getHubRewardAddress(network, REWARDS_TYPE.V2);
Refactored rewards v1 and v2, then finalized gas estimation on rewards v2