Line alignment optimization #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siarheihuzarevich
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across multiple files, primarily focusing on Cypress tests, package updates, and refactoring for dependency injection and method improvements. The most important changes include updates to Cypress test cases, dependencies in
package.jsonfiles, and refactoring of classes to use Angular'sinjectfunction.Cypress Test Improvements:
cypress/e2e/assign-node-to-connection-on-drop.component.cy.ts: Adjusted mouse event parameters to ensure accurate drag-and-drop functionality.cypress/e2e/drag-to-connect.component.cy.ts: AddedscrollIntoViewto ensure the element is visible before performing actions.Dependency Updates:
package.json: Updated@foblex/2ddependency version from1.1.7to1.1.8.projects/f-flow/package.json: Updated@foblex/2ddependency version from1.1.7to1.1.8and incremented the library version to17.1.0. [1] [2]Refactoring for Dependency Injection:
projects/f-flow/src/domain/f-flow/get-flow-state/get-flow-state-connections/get-flow-state-connections.execution.ts: Replaced constructor injection with Angular'sinjectfunction and extracted mapping logic into a private method. [1] [2]projects/f-flow/src/domain/f-flow/get-flow-state/get-flow-state.execution.ts: Refactored to use Angular'sinjectfunction and renamed private methods for consistency. [1] [2]projects/f-flow/src/domain/f-line-alignment/add-line-alignment-to-store/add-line-alignment-to-store.execution.ts: Corrected the property assignment in thehandlemethod.projects/f-flow/src/domain/f-line-alignment/remove-line-alignment-from-store/remove-line-alignment-from-store.execution.ts: Corrected the property assignment in thehandlemethod.Additional Improvements:
projects/f-flow/src/domain/f-node/calculate-nodes-bounding-box-normalized-position/calculate-nodes-bounding-box-normalized-position.execution.ts: Enhanced method to accept an optional parameter for nodes, improving flexibility.projects/f-flow/src/domain/log-execution-time.ts: Added a new utility functionLogExecutionTimeto measure and log the execution time of methods.These changes enhance the robustness of the test cases, update dependencies for better compatibility, and improve the maintainability and readability of the codebase through refactoring.