Replace kpad_mask with q_lengths and k_lengths
#20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a proof-of-concept for how we can rethink batching as stacking contexts as a block-diagonal in the attention space, masking any interactions between contexts of different "documents", and skipping tiles that are fully masked. For training runs with high variability in sequence length, it avoids a huge amount of needless computation on padding tokens. Dense layers in a model stack also benefit from this.
Ideally this would be generalized to fully-fledged flex attention, but even then,
document_idsandlengthsmight need to be a special case to efficiently construct a block mask.See also Flex Attention

