[WIP] Feature/multidimension array - Rank 2 - Rank 4 support #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7 +/- ##
==========================================
+ Coverage 92.07% 92.09% +0.02%
==========================================
Files 4 4
Lines 618 1227 +609
==========================================
+ Hits 569 1130 +561
- Misses 49 97 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* This resolves issue #8
…for-products-of-functions
fixes issues with function strings that are long
…ucts-of-functions 8 incorrect results for products of functions
Many r3 &r4 tests are failing atm
fluidnumerics-joe
changed the title
Currently supporting rank 1 - rank 4 arrays
Continually missing this one causes reduction in coverage percentage
Boost coverage
|
coverage now at 92.09% .. good to go here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support for rank 2 through rank 4 p32 and fp64 arrays.