Fix monadic token priority to resolve issue #31 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Intel ifort compiler builds fail on parsing_* tests; errors suggest priority value was unset. This patch preserves previous behavior for operators in addition to increasing monad priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The priority function, which is used in infix to postfix conversion, has been updated to separate out function, operator, and monad token types and assign priority for order of operations within each class. Functions and monads take highest priority; Monads ( negative signs in front of numbers, variables, and parentheses) need highest priority so that the sign flip is applied immediately after a number or variable is pushed on to the evaluation stack.
A new test is added, based on the MWE from @angelog0 in issue #31 to ensure this issue remains covered in tests
Resolves #31