Skip to content

fix: resolve missing dependencies for Windows Kafka SASL support #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrick-stephens merged 1 commit into from
Dec 23, 2025
Merged

fix: resolve missing dependencies for Windows Kafka SASL support #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 31 additions & 22 deletions source/cmake/kafka.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,53 +9,62 @@ include(FindPkgConfig)

# Check for libsasl2 (required for SASL authentication)
set(FLB_SASL_ENABLED OFF)
if(PkgConfig_FOUND)
pkg_check_modules(SASL libsasl2)
if(SASL_FOUND)
message(STATUS "Found libsasl2: ${SASL_VERSION}")
set(FLB_SASL_ENABLED ON)
if( FLB_SYSTEM_WINDOWS )
# On Windows, we only need TLS support to enable SASL support in librdkafka
if( NOT FLB_TLS )
message(WARNING "TLS support is required to enable SASL on Windows")
endif()
set(FLB_SASL_OAUTHBEARER_ENABLED ${FLB_TLS})
# Note we do not want to configure FLB_SASL_ENABLED on Windows as this then requires the library to link with
else()
message(WARNING "pkg-config not available - trying fallback SASL detection")
endif()

# Fallback when pkgconfig is not available or not working properly (centos 6)
if(NOT FLB_SASL_ENABLED)
find_library(SASL2_LIB NAMES sasl2)
find_path(SASL2_INCLUDE NAMES sasl/sasl.h)
if(SASL2_LIB AND SASL2_INCLUDE)
set(FLB_SASL_ENABLED ON)
message(STATUS "Found libsasl2 via fallback: ${SASL2_LIB}")
if(PkgConfig_FOUND)
pkg_check_modules(SASL libsasl2)
if(SASL_FOUND)
message(STATUS "Found libsasl2: ${SASL_VERSION}")
set(FLB_SASL_ENABLED ON)
endif()
else()
message(WARNING "libsasl2 not found - SASL authentication will be disabled")
message(WARNING "pkg-config not available - trying fallback SASL detection")
endif()

# Fallback when pkgconfig is not available or not working properly (centos 6)
if(NOT FLB_SASL_ENABLED)
find_library(SASL2_LIB NAMES sasl2)
find_path(SASL2_INCLUDE NAMES sasl/sasl.h)
if(SASL2_LIB AND SASL2_INCLUDE)
set(FLB_SASL_ENABLED ON)
message(STATUS "Found libsasl2 via fallback: ${SASL2_LIB}")
else()
message(WARNING "libsasl2 not found - SASL authentication will be disabled")
endif()
endif()
# OAuth Bearer is built into librdkafka when SASL is available
set(FLB_SASL_OAUTHBEARER_ENABLED ${FLB_SASL_ENABLED})
endif()

# OAuth Bearer is built into librdkafka when SASL is available
set(FLB_SASL_OAUTHBEARER_ENABLED ${FLB_SASL_ENABLED})

# MSK IAM requires OAuth Bearer support
set(FLB_KAFKA_MSK_IAM_ENABLED ${FLB_SASL_OAUTHBEARER_ENABLED})

# Configure librdkafka options
FLB_OPTION(WITH_SASL ${FLB_SASL_ENABLED})
FLB_OPTION(WITH_SSL On)
FLB_OPTION(WITH_SSL ${FLB_TLS})
FLB_OPTION(WITH_SASL_OAUTHBEARER ${FLB_SASL_OAUTHBEARER_ENABLED})
FLB_OPTION(WITH_SASL_CYRUS ${FLB_SASL_ENABLED})

# Export compile-time definitions using FLB_DEFINITION macro
if(FLB_SASL_ENABLED)
FLB_DEFINITION(FLB_HAVE_KAFKA_SASL)
message(STATUS "Kafka SASL authentication: ENABLED")
else()
message(STATUS "Kafka SASL authentication: DISABLED")
elseif(NOT FLB_SYSTEM_WINDOWS)
message(FATAL_ERROR "Kafka SASL authentication: DISABLED")
endif()

if(FLB_SASL_OAUTHBEARER_ENABLED)
FLB_DEFINITION(FLB_HAVE_KAFKA_OAUTHBEARER)
message(STATUS "Kafka OAuth Bearer: ENABLED")
else()
message(STATUS "Kafka OAuth Bearer: DISABLED")
message(FATAL_ERROR "Kafka OAuth Bearer: DISABLED")
endif()

# Disable Curl on macOS (if needed)
Expand Down
Loading