Fix reflected XSS with symbol parameter phacility#50

FluentDevelopment · Nov 26, 2020 · ed08552 · ed08552
1 parent 2b14d1a
commit ed08552
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/extension/php_xhprof.h b/extension/php_xhprof.h
@@ -39,7 +39,7 @@ extern zend_module_entry xhprof_module_entry;
  */
 
 /* XHProf version                           */
-#define XHPROF_VERSION       "2.2.2-dev"
+#define XHPROF_VERSION       "2.2.3"
 
 #define XHPROF_FUNC_HASH_COUNTERS_SIZE   1024
 

diff --git a/xhprof_lib/utils/xhprof_lib.php b/xhprof_lib/utils/xhprof_lib.php
@@ -909,6 +909,10 @@ function xhprof_param_init($params) {
       $p = implode(',', array_filter(explode(',', $p), 'ctype_xdigit'));
     }
 
+    if ($k == 'symbol') {
+        $p = strip_tags($p);
+    }
+
     // create a global variable using the parameter name.
     $GLOBALS[$k] = $p;
   }