Skip to content

exclude pnpm lock file from prettier formatting#5864

Open
jocelynlin-wd wants to merge 1 commit intomainfrom
chore/pnpm-lock-file-format
Open

exclude pnpm lock file from prettier formatting#5864
jocelynlin-wd wants to merge 1 commit intomainfrom
chore/pnpm-lock-file-format

Conversation

@jocelynlin-wd
Copy link
Contributor

  • Add .prettierignore file to exclude pnpm-lock.yaml from formatting
  • update pnpm-lock.yaml to use generated format

…pdate pnpm-lock.yaml to use generated format
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a configuration change to prevent Prettier from formatting the pnpm-lock.yaml file. By adding this file to .prettierignore, the project ensures that the lock file's structure remains consistent with its generated format, avoiding potential conflicts or unintended modifications during code formatting.

Highlights

  • Prettier Configuration: A new .prettierignore file was added to explicitly exclude pnpm-lock.yaml from Prettier's formatting process.
Changelog
  • .prettierignore
    • Added pnpm-lock.yaml to prevent Prettier from formatting it.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly adds a .prettierignore file to exclude pnpm-lock.yaml from formatting. This is a good practice. I've added one suggestion to enhance this by including other paths that are typically ignored, to align with the existing ESLint configuration for better consistency and robustness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants