Vaadin 24.8 DownloadHandler Breaks Cropping #22

Activity

1. paodb

   added this to Flowing Code Addonson Jul 25, 2025
2. github-project-automation

   moved this to Inbox (needs triage) in Flowing Code Addonson Jul 25, 2025
3. javier-godoy commented on Aug 4, 2025

   

   javier-godoy

   on Aug 4, 2025

   Member

   More actions

   Hello. The ImageCrop(Image) constructor currently only supports images with a fixed src, not dynamic resources like DownloadHandler or StreamResource.

   We have created issue #24 to deprecate the current constructor. This issue will remain open to track the future implementation of support for DownloadHandler and StreamResource.

   👍React with 👍1Reacted by sveinnetnordic
4. javier-godoy

   added

   enhancementNew feature or requestNew feature or request

   on Aug 4, 2025
5. javier-godoy

   moved this from Inbox (needs triage) to To Do in Flowing Code Addonson Aug 4, 2025
6. realulim commented on Sep 29, 2026

   

   realulim

   on Sep 29, 2026

   More actions

   I cannot reproduce this issue with version 1.2.2 of ImageCrop. I also have a Vaadin application and recently upgraded it to the new DownloadHandler API and I can see the preview image and the cropping rectangle without any problems. I cannot test the cropping action per se, because for that I need some features I implemented in a fork (https://github.com/iSYS-Software/ImageCrop).

   Anyway, to perhaps help debug this, here is my Vaadin Code to set the source of the preview image:

   Image previewImage = ...
   byte[] content = ...
   String fileName = ...
   previewImage.setSrc(DownloadHandlers.fromInputStream(event ->
                   new DownloadResponse(new ByteArrayInputStream(content), fileName, "image/jpeg", content.length),
                   fileName
               ).inline());
   
   DownloadHandlers.java:
   public static InputStreamDownloadHandler fromInputStream(InputStreamDownloadCallback callback, String fileName) {
       return new InputStreamDownloadHandler(callback) {
           @Override
           public String getUrlPostfix() {
               return fileName;
           }
       };
   }
   
7. realulim commented on Sep 30, 2026

   

   realulim

   on Sep 30, 2026

   Last edited by realulim

   More actions

   Adding to my previous comment: I have now tested the newly released 1.3.0 of ImageCrop and found no issues. I could also test cropping per se now and my test suite is green. So I am now replacing my fork with the upstream again and suspect this issue could be closed, unless the original reporter still sees a problem.
8. paodb commented on Oct 8, 2026

   

   paodb

   on Oct 8, 2026

   Member

   More actions

   Thanks @realulim for the feedback! However, this issue shouldn't be closed yet: the problem still happens in scenarios where the original Image is not attached or visible (e.g. when it's only used to build the cropper), both in Vaadin 24.8 and 25. We are going to work on it.

   As mentioned before by Javier, the idea is:

   • Add ImageCrop(DownloadHandler) and setImageSrc(DownloadHandler), so the resource is registered to the ImageCrop itself instead of depending on another Image.
   • Add the equivalent StreamResource overloads. Since StreamResource is deprecated for removal since Vaadin 24.8, it will likely be deprecated too, mirroring Image.setSrc(AbstractStreamResource).
9. paodb commented on Oct 9, 2026

   

   paodb

   on Oct 9, 2026

   Member

   More actions

   A quick update on the plan above: this is being addressed in #37.

   • It will be released in 2.0.0, which requires Vaadin 24.8+ (and supports Vaadin 25), since DownloadHandler is only available from Vaadin 24.8 on. Version 1.x remains available for earlier Vaadin 24 versions.
   • 2.0.0 works only with the new API, so the StreamResource overloads won't be added after all.
   • The deprecated ImageCrop(Image) constructor is removed in 2.0.0. Use ImageCrop(String) or ImageCrop(DownloadHandler) instead.

   👍React with 👍1Reacted by Javier Godoy
10. paodb

    added a commit that references this issue on Oct 9, 2026

    feat: support DownloadHandler as image source

    ...

    This issue will close once commit 98d082a is merged into the 'master' branch.

    98d082a