Skip to content

feat: add DefaultDynamicTheme annotation AND fix: fall back to an application-wide default dynamic theme AND fix: do not add the dynamic theme stylesheet twice AND deprecate: deprecate DynamicTheme.initialize(AppShellSettings) - #173

Merged
javier-godoy merged 4 commits into
masterfrom
feat-172
Oct 2, 2026
Merged

feat: add DefaultDynamicTheme annotation AND fix: fall back to an application-wide default dynamic theme AND fix: do not add the dynamic theme stylesheet twice AND deprecate: deprecate DynamicTheme.initialize(AppShellSettings)#173
javier-godoy merged 4 commits into
masterfrom
feat-172

deprecate: deprecate DynamicTheme.initialize(AppShellSettings)

509650b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Oct 2, 2026 in 22s

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 178 in base/src/main/java/com/flowingcode/vaadin/addons/demo/DynamicTheme.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_CommonsDemo&issues=AaDuUSqpoWonBeEyRka-&open=AaDuUSqpoWonBeEyRka-&pullRequest=173

Check failure on line 55 in base/src/main/java/com/flowingcode/vaadin/addons/demo/DynamicThemeInitializer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_CommonsDemo&issues=AaDuUSn-oWonBeEyRka9&open=AaDuUSn-oWonBeEyRka9&pullRequest=173
View more details on SonarQubeCloud