Skip to content

Update README.md to document dateAlias method #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md to document dateAlias method #78

wants to merge 1 commit into from

Conversation

@bland-industries
Copy link

@bland-industries bland-industries commented Dec 28, 2024

I feel like date is a field name that would be common enough that documentation is needed to help those who find bugs in the results of the Trend aggregation.

@bland-industries bland-industries marked this pull request as ready for review December 28, 2024 18:15
@bland-industries
Copy link
Author

bland-industries commented Dec 28, 2024

The other option is to change the Trend class public string $dateAlias = 'date'; variable to be public string $dateAlias = 'date_alias'; so that it would conflict less with developers table fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bland-industries