Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the SHM-jemalloc session glue layer account for the realistic possibility that when one uses session.lend/borrow_object() to transmit native structures residing in SHM, those operations can fail due to session being down at that time. More or less that means (1) correcting a few log messages and comments and (2) do not "helpfully" assert on things that might not always be true. / Comment and/or doc changes. #53

Merged
merged 2 commits into from
Dec 13, 2024
Merged

In the SHM-jemalloc session glue layer account for the realistic possibility that when one uses session.lend/borrow_object() to transmit native structures residing in SHM, those operations can fail due to session being down at that time. More or less that means (1) correcting a few log messages and comments and (2) do not "helpfully" assert on things that might not always be true. / Comment and/or doc changes. #53

merged 2 commits into from
Dec 13, 2024
+37 −22

Conversation

ygoldfeld
Copy link
Contributor

No description provided.

@ygoldfeld
Comment and/or doc changes.
f436f9e
@ygoldfeld
In the SHM-jemalloc session glue layer account for the realistic poss…
fa75c37 
…ibility that when one uses session.lend/borrow_object() to transmit native structures residing in SHM, those operations can fail due to session being down at that time. More or less that means (1) correcting a few log messages and comments and (2) do not "helpfully" assert on things that might not always be true.
@ygoldfeld
Copy link
Contributor Author

Thanks, Will.

@ygoldfeld ygoldfeld merged commit 30fbea3 into main Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkorbe wkorbe wkorbe approved these changes

@echan-dev echan-dev Awaiting requested review from echan-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ygoldfeld @wkorbe