Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add:封装niuniu的数据库操作 #61

Merged
merged 29 commits into from
Dec 22, 2024
Merged

add:封装niuniu的数据库操作 #61

merged 29 commits into from
Dec 22, 2024

Conversation

xyy0411
Copy link
Contributor

@xyy0411 xyy0411 commented Nov 2, 2024

No description provided.

fumiama
fumiama requested changes Nov 3, 2024
View reviewed changes
Copy link
Member

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model自己的私有函数可以是基础的接口，但是导出的公开函数必须是高层的抽象。牛牛的复杂玩法都要放进去，方便统一管理。

README.md Outdated Show resolved Hide resolved
niuniu/niuniu.go Outdated Show resolved Hide resolved
niuniu/niuniu.go Outdated Show resolved Hide resolved
niuniu/niuniu.go Outdated Show resolved Hide resolved
niuniu/niuniu.go Outdated Show resolved Hide resolved
niuniu/niuniu.go Outdated Show resolved Hide resolved
niuniu/niuniu.go Outdated Show resolved Hide resolved
niuniu/niuniu.go Outdated Show resolved Hide resolved
niuniu/niuniu.go Outdated Show resolved Hide resolved
fumiama
fumiama requested changes Nov 10, 2024
View reviewed changes
Copy link
Member

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

搬太多了，实际上就是一股脑全搬过来罢了，这完全不是我想要的效果。这样写不如不搬。AnimeAPI是和ZeroBot和zbpuitls解耦的，禁止增加这两个依赖。如果你能在没有这两个依赖的情况下完成这个包，那我会再仔细看你的实现。

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
fumiama
fumiama requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有些问题之前就提过这次又出现，希望能举一反三。暂时这些吧，有点看不下去了。

go.mod Outdated Show resolved Hide resolved
niu/main.go Show resolved Hide resolved
niu/main.go Outdated Show resolved Hide resolved
niu/main.go Outdated Show resolved Hide resolved
niu/main.go Outdated Show resolved Hide resolved
niu/main.go Outdated Show resolved Hide resolved
niu/main.go Outdated Show resolved Hide resolved
fumiama
fumiama requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

并发地狱。。。你要两把锁，一把是数据库的，另一把是API本身的。

go.mod Outdated Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
niu/main.go Outdated Show resolved Hide resolved
fumiama
fumiama previously approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

该修lint了（

fumiama
fumiama reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

继续继续⛽️

@fumiama fumiama merged commit 19192b0 into FloatTech:main Dec 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fumiama fumiama fumiama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xyy0411 @fumiama