Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FDG-4026: Remove Capacity Comaprison Check for capacity-scheduler #6

Open
wants to merge 1 commit into
base: fdp-branch-2.9.0
Choose a base branch
from
Open

FDG-4026: Remove Capacity Comaprison Check for capacity-scheduler #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...n/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CSQueueUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@ private static void capacitiesSanityCheck(String queueName,
for (String label : queueCapacities.getExistingNodeLabels()) {
float capacity = queueCapacities.getCapacity(label);
float maximumCapacity = queueCapacities.getMaximumCapacity(label);
if (capacity > maximumCapacity) {
throw new IllegalArgumentException("Illegal queue capacity setting, "
+ "(capacity=" + capacity + ") > (maximum-capacity="
+ maximumCapacity + "). When label=[" + label + "]");
}
// Only, absCapacity <= absMaximumCapacity should be checked as relative capacity and relative maximum capacity
// have no relation
// E.g. Parent Queue has Relative Capacity 30% and Relative Max Capacity 60%, while child queue has relative
// Capacity 100% and Relative Max Capacity 60%. Absolute Capacity of Child queue is still 30% and
// absolute Maximum Capacity is 36% which is valid.

// Actually, this may not needed since we have verified capacity <=
// maximumCapacity. And the way we compute absolute capacity (abs(x) =
Expand Down