Restapi caller #48
Open
Restapi caller #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 28, 2015 18:20
| Gson gson = new GsonBuilder().serializeNulls().create(); | ||
| String payload = gson.toJson(eventMap); | ||
| Map<String, String> headers = new HashMap<String, String>(); | ||
| headers.putAll(staticHeaderProvider.getHeaders()); |
There was a problem hiding this comment.
null checks on these values. These will be implemented by any client and there will be idiots who will return null if they dont want to send out any custom/static headers.
|
I see that most of the new code/classes do not have code documentation - class summary, copyright notice and such. Can you please add these in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Layer for making a post call to the configured URI with the event as json payload.