Rename Throwable property + introduce typed-throw overloads to first common APIs #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n0rthk1n9
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3
Note that I found that naming the
ThrowablepropertylocalizedDescriptiondid not lead to compiler errors as expected when the property is forgotten. Probably due toThrowablerequiring conformance toErrorwhich has a default value for it. So I had to rename it, so I renamed everything touserFriendlyMessagewhich I find most intuitive.But the main part of this PR is the addition of the
FileManagerandURLSessionoverloads. I also added a README section again to explain the motivation behind these overloads. I admit, it's not a very detailed explanation, but I think we can improve as we use these overloads in real-world apps and have more concrete examples showcasing their advantage.