Improve chart viz for event values not around zero#2244
Open
Flix6x wants to merge 2 commits into
Open
Conversation
…s in the chart for multiple sensors Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Member
|
Can we in principle add a checkbox, to re-render the page with all charts including zero? |
Member
Author
|
I'm not a fan of the whole checkbox + session variable approach. I prefer these things to be part of the chart specs, so you can set them per asset rather than per user session. The data should not look different depending on who is viewing. So then the toggle (or an alternative axis domain settting) should become part of the |
Member
|
Where would the user set that? |
Member
Author
|
In the modal for editing sensors_to_show. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
documentation/changelog.rstLook & Feel
Before:
After:
How to test
...
Further Improvements
I'm not sure if this is always a good choice. Needs testing.
Related Items
...