-
Notifications
You must be signed in to change notification settings - Fork 48
Feat: Return inflexible device schedules from StorageScheduler #1994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Ahmad-Wahid
wants to merge
14
commits into
main
Choose a base branch
from
feat/multi-asset-scheduling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+67
−0
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f080655
fix: drop a dictionary from flexmodel that has no sensor
Ahmad-Wahid 56d9a96
feat: return inflexible device sensors data along with schedules
Ahmad-Wahid c122cc0
Merge branch 'main' into feat/multi-asset-scheduling
Ahmad-Wahid 54b79b8
fix: support a single flex model which is not in a list
Ahmad-Wahid 25a3815
fix: unpack all available returns
Ahmad-Wahid cf56642
fix: unpack all available returns for all cases
Ahmad-Wahid a8ab9ea
Merge remote-tracking branch 'origin/main' into feat/multi-asset-sche…
Ahmad-Wahid 19d287c
Merge remote-tracking branch 'origin/main' into feat/multi-asset-sche…
Ahmad-Wahid 5e92a82
Merge remote-tracking branch 'origin/main' into feat/multi-asset-sche…
Ahmad-Wahid fc6fd8c
Merge remote-tracking branch 'origin/main' into feat/multi-asset-sche…
Ahmad-Wahid 983fa90
Merge remote-tracking branch 'origin/main' into feat/multi-asset-sche…
Ahmad-Wahid cb79ea7
Merge remote-tracking branch 'origin/main' into feat/multi-asset-sche…
Ahmad-Wahid d2b7d93
Merge remote-tracking branch 'origin/main' into feat/multi-asset-sche…
Ahmad-Wahid 53e5cb7
skip saving inflexible-devices schedules
Ahmad-Wahid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know why this can happen. It happens when the db flex model of an asset is picked up when its parent asset is being scheduled. That means some devices are included in the optimization with only an asset ID known, and the power sensor ID to save the results is not guaranteed to be known.
Let's discuss what that means for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually want to keep support for device flex-models that don't have a power sensor defined. Such a device may have a complete flex-model description, but just lacking a place to store its scheduling results. And by now we also have the
consumptionandproductionfields that users can use to define where results need to be stored.