added the supervised interfaces #67
Conversation
|
|
||
| import com.flash3388.flashlib.control.Stoppable; | ||
|
|
||
| public interface Supervisable extends Stoppable { |
There was a problem hiding this comment.
Supervisable isn't the best name for it. I understand where it comes from, but saying supervision implies something completely different.
Maybe something around Limit?
| import com.flash3388.flashlib.control.Stoppable; | ||
| import com.flash3388.flashlib.scheduling.Requirement; | ||
|
|
||
| public interface SupervisedMovable extends Stoppable, Supervisable, Requirement { |
There was a problem hiding this comment.
You could just extend Movable... You wouldn't need to provide the defaults in that case.
Do the same with the rest.
|
|
||
| public interface SupervisedMovable extends Stoppable, Supervisable, Requirement { | ||
|
|
||
| default void supervisedMove(double speed) { |
There was a problem hiding this comment.
It kinda sounds like it should almost be implicit (the idea that the motion is supervised), such that a call to move is automatically supervised.
Remember that it's an interface, you don't actually need to provide all the capabilities in it with default, simply require someone to implement it to your specifications.
Same for rest.
There was a problem hiding this comment.
I forgot to do it... I just copied them and didnt finish it lol
| * | ||
| * @since FlashLib 2.0.0 | ||
| */ | ||
| public interface SupervisedMovable2D extends SupervisedMovable, Requirement { |
There was a problem hiding this comment.
You copied the documentation.... Fix it to something correct.
| void move(Vector2 motionVector); | ||
|
|
||
| @Override | ||
| default void supervisedMove(double speed) { |
There was a problem hiding this comment.
Why do you re-do the default here?
Not sure about this one... close #66